Review of "Refresh Rate Governor" version 1.2.0 (1)

Details Page Preview

Automatically switch the screen refresh rate depending on the power supply status

Extension Homepage
https://github.com/sasas991/gnome-refresh-rate-governor

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version Status
1.2.0 (3) Active
1.2.0 (2) Active
1.2.0 (1) Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove files and folders: - `screenshot.png` - `po` - `Makefile` [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 2. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages. 3. Better to remove `session-modes`. It's really not needed to change the refresh rate on lock screen: [EGO Review Guidelines: Metadata Session Modes](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#session-modes) 4. Also null out in disable: ```js this._settings = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 5. Don't use sync spawn since that can freeze the shell process (line 61 `extension.js`): [GJS Guide: Subprocesses](https://gjs.guide/guides/gio/subprocesses.html#complete-examples) 6. Please use d-bus `org.gnome.Mutter.DisplayConfig`, instead of the spawn commands you are using: [D-Bus Guide](https://gjs.guide/guides/gio/dbus.html) 7. Move line 12 `extension.js` to enable. Avoid calling functions in global scope: [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources)