Show upcoming meetings on your calendar
Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.
| Version | Status |
|---|---|
| 1.0.0 (2) | Unreviewed |
| 1.0.0 (1) | Rejected |
1. There are many unnecessary try-catch wrappers in both `extension.js` and `lib/calendarUtils.js`. You should never use try-catch for something that never throws. Also, so many unnecessary `=== 'function'`. Please note, we have a rule for AI usage here on EGO: [EGO Review Guidelines: AI](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-must-not-be-ai-generated) 2. `this._destroyed` is a bad practice. Your instance should be nulled out after calling destroy so it is not getting used after. 3. Remove line 1668-1673, 1686-1691, 1695 `extension.js`. Not needed. 4. Timeout should be removed on destroy and before creating a new one (line 235 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 5. Move line 1542-1527 `extension.js` to `destroy()`. That's not signal. 6. While I understand the REGEX checks in `lib/meetingServices.js` are just for finding specific URLS, that's really heavy for the GNOME Shell process doing in loops. 7. I highly recommend to move this code to a separate app and use it as dependency for this extension. That way, you aren't doing too much in GNOME Shell process. Just communicating with D-Bus: [D-Bus Guide](https://gjs.guide/guides/gio/dbus.html) I'm saying that, because this code is doing too much calculation, that is not really suited for the shell process. You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions