Review of "Hati Cursor Highlighter" version 2

Details Page Preview

Professional cursor highlighting for presentations and screen recording.

Extension Homepage
https://github.com/szymonwilczek/hati

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version Status
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Bad schemas path. It should starts with `org.gnome.shell.extensions.`. 2. You are checking for `this._interfaceSettings` while not disconnecting it (line 106 `extension.js`). 3. Move everything out of the entry point in `extension.js` and only hold the logic there. Didn't fully reviewed that for cleanup but it needs so many properties to be destroyed and nulled out on disable: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 4. Please use aysnc for reading file content since you are in shell process (line 24 `shaders/shaders.js`): [Gio.File.load_contents_async](https://gjs-docs.gnome.org/gio20~2.0/gio.file#method-load_contents_async) 5. Don't need to use any parameters for `this.getSettings()` since you already have that in `metadata.json`. 6. Avoid sending large code/diff. It's hard to review. You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions