Review of "Doomsday" version 1

Details Page Preview

Display D-Day countdowns in the top panel bar. Track important events with customizable countdown timers.

Extension Homepage
https://github.com/devastator-x/doomsday

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version Status
5 Active
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove version from the import (line 1 `prefs.js`). 2. Please don't store any instance of objects in a property in the default class you are exporting in `prefs.js`. that won't allow the garbage collector to do its job after window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) If you don't want to make them local to `fillPreferencesWindow()` function, you can clean up on: ```js window.connect('close-request', () => { // clean up here }); ``` You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
devastator-x posted a review
Thank you for the review! - Removed version from Gtk import in prefs.js - Refactored to use local variables instead of instance properties, and added close-request cleanup for proper GC - Added donations field to metadata.json