Review of "narrow-space" version 1

Details Page Preview

A tiling window manager on top of gnome

Extension Homepage
https://github.com/benjaminGraef/narrow-space

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version Status
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please use aysnc for reading file content since you are in shell process (line 28 `KeybindingConfigLoader.js`): [Gio.File.load_contents_async](https://gjs-docs.gnome.org/gio20~2.0/gio.file#method-load_contents_async) 2. Please remove `TODO`: [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 3. Remove `license` from `metadata.json`. 4. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages. 5. Remove `this._enabled` from `extension.js`. It is a bard practice. 6. Move line 108 `extension.js` to the end of `disable()` to avoid racy situations. 7. Also cleanup `this.workspaces` in disable: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions