Review of "DNS-Switcher" version 2

Details Page Preview

One-click DNS switching (DNS server lists can be easily modified in the menu)

Extension Homepage
https://github.com/ubuntu/gnome-shell-extension-appindicator

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version Status
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Remove `metadata-version` from `metadata.json`. 2. Bad URL in `metadata.json`. 3. Please use aysnc for reading file content since you are in shell process (line 98 `extension.js`): [Gio.File.load_contents_async](https://gjs-docs.gnome.org/gio20~2.0/gio.file#method-load_contents_async) 4. You have `this.openPreferences()` in the entry point. You cannot use spawn command for that (line 131 `extension.js`). 5. Don't use sync spawn since that can freeze the shell process (line 143 `extension.js`): [GJS Guide: Subprocesses](https://gjs.guide/guides/gio/subprocesses.html#complete-examples) 6. Anyway, you shouldn't use any of those spawn commands. You should use d-bus: [D-Bus Guide](https://gjs.guide/guides/gio/dbus.html) 7. Please remove all of the unnecessary comments. You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions