Review of "Quran Radio" version 1

Details Page Preview

Live Qur'an radio streaming extension with 170+ stations and full RTL support

Extension Homepage
https://github.com/dhiflaoui/gnome_quran_radio

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:822
        this.menu.connect('open-state-changed', (menu, open) => {
          if (!open) {
            this._searchEntry.text = '';
            this._searchQuery = '';
            // Close language menu when main menu closes
            this._closeLanguageMenu();
          }
        })

All Versions

Version Status
2 Unreviewed
1 Rejected

Previous Reviews on this Version

SriramRamkrishna rejected
Hello, can you look through the warnings and fix them and then resubmit?