Review of "TouchUp" version 1.4.0 (15)

Details Page Preview

Enhances various aspects of the GNOME experience when using a touch device. Current features: - Navigation bar (gestures and buttons mode), as known from Android - Touch gestures for notifications (dismiss, collapse, expand) - Make the notification area touch-scrollable - Onscreen Keyboard: key popups, extended keys, swipe to close. - Manually open the keyboard by swiping up the bottom left navigation bar edge - Floating rotate button when auto-rotation is off, as known from Android - Overview and desktop background gestures (switch workspaces, open/close overview) - Overview window preview gestures (swipe up to close windows, hold+move to drag) - Double tap panel, desktop background or lockscreen to lock & sleep A lot more is planned; take a look at the roadmap for that: https://github.com/mityax/gnome-extension-touchup If you find this extension valuable, please donate to make sure the work can go on! :)

Extension Homepage
https://github.com/mityax/gnome-extension-touchup

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
1.4.0 (16) Active
1.4.0 (15) Rejected
1.3.5 (14) Active
1.3.4 (13) Active
1.3.3 (12) Active
1.3.2 (11) Active
1.3.1 (10) Active
1.3.0 (9) Active
1.3.0 (8) Rejected
1.2.2 (7) Active
1.2.1 (6) Rejected
1.2.0 (5) Active
1.1.0 (4) Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. The new `core` modules just making the extension hard to follow for reviewers. 2. Better to use `connectObject()` and `disconnectObject()` for easier cleanup instead of holding the signals in a variable. 3. The reason for using `session-modes` should be mentioned in disable comment: [EGO Review Guidelines: Session Modes](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#session-modes)
mityax posted a review
Thanks for your review! 1. Since most modules were just moved into the directory and remained unchanged otherwise, I assume you're talking about the new `ExtensionFeatureManager`. However, I believe that without this class the code will be harder to maintain and review, since basically every feature would need to re-implement the same functionality for enabling/disabling it depending on overall extension state, settings, and sessionModes. Also, this module will only rarely need changes, so when it's properly reviewed once, it'll not cause much more work in the future. If you could specify what exactly might make reviewing hard, that might be helpful. Otherwise, I could do some minor cleanup to make things more clear – e.g. rename `features` to `enabledFeatures`, add clarifying comments, reorder methods where it makes sense, so reviewing is eased a little. Would that work for you? 2. Sure, I'll refactor this. 3. Thanks, I missed that. Would this comment work or are there any more requirements? /* This extension requires the "unlock-dialog" session mode, since some feature also support running on the lockscreen (see the `sessionModes` parameter of `TouchUpExtension.defineFeature`). Currently, it's these features specifically: - DoubleClickToSleep: Supports double tapping the `ScreenShield` to suspend the device */
JustPerfection posted a review
You can keep the comment small and easier to read. Something like: ``` Session Modes: This extension uses "unlock-dialog" session mode for some lock screen features: - DoubleClickToSleep: Double tap `ScreenShield` to suspend ```