Review of "Keyboard Sounds" version 1

Details Page Preview

Adds mechanical keyboard and mouse click sound effects to your desktop. Requires the keyboardsounds Python package (pip install keyboardsounds). Features: * Toggle keyboard and mouse sounds from the panel * Choose from 15+ built-in sound profiles * Adjustable volume

Extension Homepage
https://github.com/baraa404/gnome-keyboard-sounds

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection waiting for author
Why sending the same extension with different UUID while asked about the AI usage? https://extensions.gnome.org/review/68411
baraa posted a review
well i updated some stuff im pretty new to this kind of thing i didnt know i can uplode it or modfiy and i havent read the guidelines the first time but now i did and yes i used some ai but not fully built upon it
baraa posted a review
well i updated some stuff im pretty new to this kind of thing i didnt know i can uplode it or modfiy and i havent read the guidelines the first time but now i did and yes i used some ai but not fully built upon it
baraa posted a review
JustPerfection rejected
1. Please remove all of the subprocess commands and use d-bus instead: [D-Bus Guide](https://gjs.guide/guides/gio/dbus.html) 2. Don't need to use any parameters for `this.getSettings()` since you already have that in `metadata.json`. You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
baraa posted a review
Hey, Thanks for the review! I looked into the D-Bus thing and unfortunately kbs doesn't have a D-Bus API at all. I checked the source code and ran busctl while it was running — nothing there. The tool only exposes a TCP socket for some runtime commands, but for starting/stopping/getting status you have to use the CLI. Since this extension is literally just a GUI wrapper for the kbs command, subprocess calls are kind of unavoidable. They're all async though, so they shouldn't block anything. The other two items are fixed: - Removed the schema arg from getSettings() - Added the donations field Cheers