Review of "WiFi Signal Plus" version 1

Details Page Preview

Displays WiFi generation (4/5/6/7) in the top bar with detailed connection info on hover

Extension Homepage
https://github.com/JalilArfaoui/gnome-extension-wifi-signal-plus

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
7 Unreviewed
6 Rejected
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please use empty new lines between functions and classes. 2. Remove the timeout before creating a new one (line 358 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 3. Don't use sync spawn since that can freeze the shell process (line 99 `wifiInfo.js`): [GJS Guide: Subprocesses](https://gjs.guide/guides/gio/subprocesses.html#complete-examples) You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
JustPerfection posted a review
4. Please add GitHub or GitLab url to the `metadata.json`: [EGO Review Guidelines: url](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed)
JalilArfaoui posted a review
Thank you @JustPerfection for your guidance, I’ve fixed the 4 points. Can you tell me if it seems OK now ?
JustPerfection posted a review
Thanks for the fix. Newer version approved.