Review of "Gnome Email Notifications" version 31

Details Page Preview

Shows Gmail and Outlook notifications in Gnome Message Tray using Gnome Online Accounts

Extension Homepage
https://github.com/shumingch/gnome-email-notifications

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
34 Active
33 Rejected
32 Rejected
31 Rejected
30 Rejected
29 Rejected
28 Active
27 Active
26 Active
25 Active
24 Active
23 Active
22 Active
21 Active
20 Active
19 Active
18 Active
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Rejected
6 Active
5 Rejected
4 Active
3 Active
2 Active
1 Inactive

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages. 2. Remove `screenshot.png`: [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 3. Remove the unnecessary `\n` from the end of description in `metadata.json`. 4. Remove version from the import: - line 21 `InboxScanner.js` - line 14 `prefs.js` 5. Remove line 123-160 `Conf.js`. You already have `this.getSettings()` in the entry point. 6. You already have `console.*`. So no need for `console.js`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) Also, there is custom logger for 48+: [Port Guide 48: Custom Logger](https://gjs.guide/extensions/upgrading/gnome-shell-48.html#custom-logger) 7. Only line 111 `Notifier.js` would be enough. No need to use the `catch` section (fallback). 8. Move line 134-140 `extension.js` to enable and don't wrap them in try-catch. 9. What throws there that needs try-catch (line 45 `extension.js`)? [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations)
shumingch posted a review
Thanks for the review! > 9. What throws there that needs try-catch (line 45 `extension.js`)? I was trying to show an error to the user in the case of `gir1.2-goa-1.0` not being installed. Never figured it out. I'll remove the try-catch