Review of "Nowa Shell" version 3

Details Page Preview

Light visual and usability adjustments for GNOME Shell

Extension Homepage
https://github.com/nowaos/ext-nowa-shell

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
3 Unreviewed
2 Rejected
1 Rejected

Previous Reviews on this Version

alxmagro posted a review
1. Fixed; 2. Addressed below*; 3. Fixed; 4. Addressed below*; 5. `this.path` does not exist inside the DashToDockThemer submodule. I’m passing `dir` from extension.js to all submodules through BaseModule; 6. Fixed; 7. In BaseView, I decided to create a "component" with a minimal lifecycle skeleton. In future releases, I can implement automatic cleanup of timeouts or other resources directly in `destroy`, without requiring child classes to worry about calling this in `onDestroy`. * Regarding points 2 and 4, I appreciated learning about those helpers. However, if the change is not mandatory, I prefer to keep the current structure, since the codebase follows a decentralized structure. It would become more difficult if I had to load helpers from extension.js into the components, for example: ``` extension.js -> CalendarManager -> DateMenuService -> CustomCalendar (log here) ```