Review "Rocketbar 2" version 2.0 (14) - GNOME Shell Extensions

Review of "Rocketbar 2" version 2.0 (14)

by ChepKun

Taskbar and additional enhancements for the shell.

Extension Homepage: https://github.com/linux-is-awesome/gnome_extension_rocketbar

No comments.

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli found 5 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

shared/utils/sessionModesWatchdog.js:11
```
metadataFile.load_contents(null)
```

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

main/ui/taskbar/tooltip.js:107

this.#value = new St.Label(AppStatusItemValueProps)

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

main/ui/taskbar/tooltip.js:107

this.#value = new St.Label(AppStatusItemValueProps)

EGO-M-005 warning

metadata session-modes must be omitted when only user mode is declared

Field `session-modes` should be omitted when it only contains `user`.