Review of "My Little Pony Panel" version 1

Details Page Preview

Shows random My Little Pony artwork from safebooru.org in a panel popup. Includes a gallery of downloaded images.


No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO025 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

  • install.sh
    install.sh

EGO015 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:67
    this._tabGallery.connect('clicked', () => this._switchTab('gallery'))
  • extension.js:60
    this._tabPony.connect('clicked', () => this._switchTab('pony'))
  • extension.js:451
    cell.connect('clicked', () => this._galleryOpenFull(idx))
  • extension.js:76
    closeBtn.connect('clicked', () => this.emit('close-requested'))
  • extension.js:579
    this._popup.connect('close-requested', () => this._hide())

EGO016 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:465
            GLib.idle_add(GLib.PRIORITY_LOW, () => {
                try {
                    const pb = GdkPixbuf.Pixbuf.new_from_file(path);
                    const r  = Math.min(size / pb.width, size / pb.height);
                    const w  = Math.max(1, Math.floor(pb.width  * r));
                    const h  = Ma

All Versions

Version Status
1 Unreviewed