Review of "GASP - Google Analytics Stats Peak" version 3

Details Page Preview

Google Analytics Stats Peak - Track your website analytics and celebrate new visitor peaks! Shows daily/weekly/monthly stats in your panel with automatic peak tracking and notifications. Colors stats acording if we are on track to next peak, or we are behind. Green we are on track. Yellow we are shourt of getting new peak. Red we are not close to get to the new peak.


No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • lib/gaAPI.js:384
    GLib.file_get_contents(sigFile)

EGO-X-002 warning

extensions should not use synchronous subprocess APIs in shell code

Shell code should avoid synchronous subprocess APIs like `GLib.spawn_command_line_sync()` and `GLib.spawn_sync()`.

Complete Examples

  • lib/gaAPI.js:371
    GLib.spawn_sync(
                        null,
                        ['openssl', 'dgst', '-sha256', '-sign', keyFile, '-out', sigFile, dataFile],
                        null,
                        GLib.SpawnFlags.SEARCH_PATH,
                        null
                    )

EGO-L-001 warning

extension must not create GObject instances or modify shell before enable()

Resource creation or signal/source setup was found outside `enable()`.

Only use initialization for static resources

  • lib/credentialStore.js:3
    new Secret.Schema(
        'org.gnome.shell.extensions.gasp',
        Secret.SchemaFlags.NONE,
        {
            type: Secret.SchemaAttributeType.STRING,
        }
    )

All Versions

Version Status
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

SriramRamkrishna rejected
Please fix Shexli warnings and re-submit.