Review of "Panel Corners (Wedone's Version)" version 1

Details Page Preview

A GNOME shell extension to keep the old topbar corners, which were removed for GNOME 42. It also allows you to customize the rounded corners, even if you use GNOME 40 or 41. It is widely based on already existing gnome-shell code, on a merge request by Alice Mikhaylenko: https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1328, and on the original work available at https://github.com/aunetx/panel-corners.

Extension Homepage
https://github.com/WedoneOfficiel/panel-corners

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO025 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO015 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:40
            this.#connections.connect(
                Main.layoutManager,
                'monitors-changed',
                () => this.update()
            )
  • extension.js:46
            this.#connections.connect(
                global.display,
                'workareas-changed',
                () => this.update()
            )
  • extension.js:54
                this.#connections.connect(
                    Main.layoutManager,
                    'startup-complete',
                    this.load.bind(this)
                )

EGO033 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

  • prefs.js:119
    this.preferences = new Settings(Keys, this.getSettings())

All Versions

Version Status
1 Unreviewed