EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 12 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

• extension.js:248

                  console.error(
                      `[GitHub Notifications] Prefs error: ${e.message}`)

• extension.js:642

                  console.error(
                      '[GitHub Notifications] 401 Unauthorized – check token')

• extension.js:651

              console.error(
                  `[GitHub Notifications] HTTP ${status}`)

• extension.js:655

              console.error(
                  `[GitHub Notifications] Fetch error: ${e.message}`)

• extension.js:702

                  console.error(
                      `[GitHub Notifications] Mark-all-read failed: HTTP ${status}`)

• extension.js:706

              console.error(
                  `[GitHub Notifications] Mark-all-read error: ${e.message}`)

• extension.js:762

              console.error(
                  `[GitHub Notifications] Desktop notification error: ${e.message}`)

• extension.js:783

              console.error(
                  `[GitHub Notifications] Cannot open URI: ${e.message}`)

• extension.js:901

              console.error(
                  `[GitHub Notifications] Failed to resolve release URL: ${e.message}`)

• extension.js:934

              console.error(
                  `[GitHub Notifications] Cannot open URI: ${e.message}`)

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

• install.sh

  install.sh

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

• schemas/gschemas.compiled

  schemas/gschemas.compiled

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

• extension.js:218

          this._label = new St.Label({
              text: '0',
              style_class: 'github-notifications-count',
              y_align: Clutter.ActorAlign.CENTER,
              y_expand: true,
          })

• extension.js:229

  this._notifSection = new PopupMenu.PopupMenuSection()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

• extension.js:253

          this._indicator.menu.connect('open-state-changed', (_menu, open) => {
              if (open)
                  this._rebuildNotificationList();
          })

• extension.js:757

              notification.connect('activated', () =>
                  this._openNotifications())