Review of "GNOME Assistant" version 2

Details Page Preview

Home Assistant Controls

Extension Homepage
https://github.com/tinchodin/gnomeassistant.git

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 10 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:216
    console.error(`[HA Ext] Brightness update failed: ${e.message}`)
  • extension.js:261
    console.error(`[HA Ext] Temperature update failed: ${e.message}`)
  • extension.js:317
    console.error(`[HA Ext] HVAC mode update failed: ${e.message}`)
  • extension.js:355
    console.error(`[HA Ext] Volume update failed: ${e.message}`)
  • extension.js:385
    console.error(`[HA Ext] Media action failed (${service}): ${e.message}`)
  • extension.js:467
    console.error(`[HA Ext] State update failed: ${e.message}`)
  • extension.js:497
    console.error(`[HA Ext] Bulk light toggle failed: ${e.message}`)
  • extension.js:608
    console.error(`[HA Ext] Failed to refresh global states: ${e.message}`)
  • extension.js:752
    console.error(`[HA Ext] _buildLayout failed: ${e.message}`)
  • extension.js:772
    console.error(`[HA Ext] Failed to open Home Assistant URL: ${e.message}`)

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:105
    id

All Versions

Version Status
3 Unreviewed
2 Rejected
1 Rejected

Previous Reviews on this Version

tinchodin posted a review
Please considere reviewing this extension.
tinchodin posted a review
Please consider reviewing this extension.
SriramRamkrishna rejected
You have a number of logging statements that you need to get rid of. See: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#no-excessive-logging further above in the guide you can see that you can use environment variables to enable extra debug.
tinchodin posted a review
Fixed the two issues. Thanks for your time reviewing this.