Review of "Adwaita Colors Home" version 3

Details Page Preview

Syncs your icon theme with your GNOME accent color. Manages installation and updates for the Adwaita Colors icon theme.

Extension Homepage
https://github.com/dpejoh/Adwaita-Colors-Home

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-006 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

  • prefs.js:141
    this._settings        = this.getSettings()
  • prefs.js:142
    this._desktopSettings = new Gio.Settings({ schema_id: 'org.gnome.desktop.interface' })
  • prefs.js:144
    this._distroType      = detectDistroType()
  • prefs.js:145
    this._installation    = detectInstallation()
  • prefs.js:146
    this._morewaita       = detectMoreWaita()
  • prefs.js:147
    this._hasAccentColor  = this._desktopSettings.settings_schema.has_key('accent-color')
  • prefs.js:152
    this._installPage = this._buildInstallationPage()
  • prefs.js:973
    this._manualCheckLabel = new Gtk.Label({ label: '', valign: Gtk.Align.CENTER })
  • prefs.js:193
    this._activeColorDot   = makeColorDot('#3584e4', 18)
  • prefs.js:194
    this._activeColorLabel = new Gtk.Label({ label: 'Blue' })

All Versions

Version Status
6 Unreviewed
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

Khx posted a review
I've included the version in metadata.json and implemented memory leak fix and other minor fixes from a github pull request.
SriramRamkrishna posted a review
You have a few issues with: preferences classes should not retain window-scoped objects on instance fields without close-request cleanup according to shexli. Can you fix those?
SriramRamkrishna rejected