Review of "Phone HUB" version 2

Details Page Preview

ADB and Scrcpy based Phone HUB lets lets you connect your adnroid phone to your GNOME desktop, for now you can monitor your phone's battery life, use your phone as a webcam or mirror its screen.

Extension Homepage
https://github.com/oualidor/gnome-phone-hub

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4

Shexli found 4 issues that may need reviewer attention.

EGO-X-002 warning

extensions should not use synchronous subprocess APIs in shell code

Shell code should avoid synchronous subprocess APIs like `GLib.spawn_command_line_sync()` and `GLib.spawn_sync()`.

Complete Examples

  • mount.js:20
    GLib.spawn_command_line_sync(`mountpoint -q "${mountPoint}"`)

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 7 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • pairingDialog.js:219
    console.error(`PairingDialog Status Check Error: ${e.message}`)
  • pairingDialog.js:117
    console.log(`PairingDialog: PC IP is ${pcIp}, loading QR from ${qrUrl}`)
  • pairingDialog.js:190
    console.log(`PairingDialog: Checking status for ${ip}...`)
  • pairingDialog.js:198
    console.log(`PairingDialog: Server response: ${text}`)
  • pairingDialog.js:201
    console.log('PairingDialog: Device AUTHORIZED!')
  • pairingDialog.js:213
    console.log('PairingDialog: Still pending authorization...')
  • pairingDialog.js:216
    console.warn(`PairingDialog: Unexpected status code ${message.status_code}`)

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • settings.js:23
    file.load_contents(null)

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 25 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • toggle.js:115
    console.error(`Phone HUB: WebSocket connection failed: ${e.message}`)
  • toggle.js:208
    console.error(`WebSocket Parse Error: ${e.message}`)
  • toggle.js:270
    console.error(`Phone HUB: Failed to send call action '${action}': ${e.message}`)
  • toggle.js:562
    console.error(`Failed to open settings folder: ${e.message}`)
  • toggle.js:649
    console.error(`Pairing Error: ${e.message}`)
  • toggle.js:653
    console.error(`Pairing Error: ${e.message}`)
  • toggle.js:823
    console.error(`SMS Window STDERR: ${line}`)
  • toggle.js:831
    console.error(`Failed to launch SMS Window: ${e.message}`)
  • toggle.js:898
    console.error(`Failed to notify phone of unpair: ${e.message}`)
  • toggle.js:904
    console.error(e)

All Versions

Version Status
2 Rejected
1 Rejected

Previous Reviews on this Version

oualidkhial posted a review
All normal descreption
oualidkhial posted a review
Standars metadata file
oualidkhial posted a review
Normal fie with out any dangerous activity, it uses qrserver.com for qrcode generation and comuncate with the mobile ap aplication using REST
oualidkhial posted a review
good extension that satisfy the need of android mobile integration in debian/ubuntu gnone ecosystem
SriramRamkrishna rejected
the shexli linter has a few issues. Please pip3 install shexli and then run it against your extension and fix whatever the output are. If you find some false errors, just let us know that when you resubmit. Thanks.