Review of "Rygel Control" version 1

Details Page Preview

A GNOME quick setting for starting and stopping the Rygel UPnP/DLNA media server

Extension Homepage
https://github.com/byjk/gnome-shell-extension-rygel-toggle

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO016 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:73
    				GLib.timeout_add(GLib.PRIORITY_DEFAULT, 500, () => {
    					this._checkRygelStatus();
    					this._updateButtonState();
    					return GLib.SOURCE_REMOVE;
    				})
  • extension.js:87
    				GLib.timeout_add(GLib.PRIORITY_DEFAULT, 500, () => {
    					this._checkRygelStatus();
    					this._updateButtonState();
    					return GLib.SOURCE_REMOVE;
    				})

EGO028 warning

extensions should not use synchronous subprocess APIs in shell code

Shell code should avoid synchronous subprocess APIs like `GLib.spawn_command_line_sync()` and `GLib.spawn_sync()`.

Complete Examples

  • extension.js:56
    GLib.spawn_command_line_sync('pgrep -x rygel')
  • extension.js:85
    GLib.spawn_command_line_sync('rygel -s')
  • extension.js:149
    GLib.spawn_command_line_sync('pgrep -x rygel')

All Versions

Version Status
2 Unreviewed
1 Rejected

Previous Reviews on this Version

byjk auto- rejected
Auto-rejected because of new version 2 was uploaded