Review of "Double Click Activities to App Grid" version 2

Details Page Preview

Open the application grid by double clicking the activities button similarly to the super key.

Extension Homepage
https://github.com/jordanbrotherton/gnome-doubleclick-appgrid

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:8
    this._doubleClickGesture = new Clutter.ClickGesture()

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:8
    this._doubleClickGesture = new Clutter.ClickGesture()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:11
            this._doubleClickGesture.connect('recognize', () => {
              if (Main.overview.visible) {
                  const checked = Main.overview.dash.showAppsButton.checked;
                  Main.overview.dash.showAppsButton.checked = !checked;
              } else {
                  Main.overview.show(Overvi

All Versions

Version Status
2 Unreviewed
1 Active