Review of "Desktop Widgets (Desktop Clock)" version 16.0 (19)

Details Page Preview

Add widgets to the desktop. Widgets include: - Digital Clock - Analog Clock - Weather - Static Text - Images - Command Output – runs terminal commands at user defined intervals and displays the result Widgets can be freely repositioned by dragging them with your mouse. Note: The Desktop Icons extension may interfere with this feature. Please disable it temporarily to move widgets.

Extension Homepage
https://gitlab.com/AndrewZaech/azclock

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 2 warning 5

Shexli found 7 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 6 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • elements/image.js:187
    console.error(`AzClock: Error processing ${file.get_basename()} - ${e}`)
  • elements/image.js:99
    console.log(e)
  • elements/image.js:168
    console.log(`AzClock: Image file does not exist - ${filePath}`)
  • elements/image.js:208
    console.log(`Content type guess for ${url} is uncertain: ${contentType}`)
  • elements/image.js:225
    console.log(`AzClock: failed to download image - ${message.statusCode}`)
  • elements/image.js:229
    console.log(`AzClock: failed to download image - ${e}`)

EGO-X-006 warning

extensions should not use lookupByURL or lookupByUUID for current extension access

Use `this`, `this.getSettings()` or `this.path` instead of `lookupByURL()` or `lookupByUUID()` for the current extension.

`extensionUtils`

  • settings/widgetSettingsPage.js:49
    ExtensionPreferences.lookupByURL(import.meta.url)

EGO-P-002 error

GSettings schema path must use /org/gnome/shell/extensions base

GSettings schema path must start with `/org/gnome/shell/extensions`.

GSettings Schemas

  • schemas/org.gnome.shell.extensions.azclock.gschema.xml
    id='org.gnome.shell.extensions.azclock.widget-data' path=''
  • schemas/org.gnome.shell.extensions.azclock.gschema.xml
    id='org.gnome.shell.extensions.azclock.element-data' path=''

EGO-P-004 error

GSettings schema XML filename must match schema id

GSettings schema filename must match `<schema-id>.gschema.xml`.

GSettings Schemas

  • schemas/org.gnome.shell.extensions.azclock.gschema.xml
    id='org.gnome.shell.extensions.azclock.widget-data' path=''
  • schemas/org.gnome.shell.extensions.azclock.gschema.xml
    id='org.gnome.shell.extensions.azclock.element-data' path=''

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:453
    this._menu = new PopupMenu.PopupMenu(this, 0.5, St.Side.TOP)
  • extension.js:81
    this._menuManager = new PopupMenu.PopupMenuManager(this)
  • extension.js:486
    this._refreshWeatherMenuItem = new PopupMenu.PopupMenuItem(_('Refresh Weather'))

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:453
    this._menu = new PopupMenu.PopupMenu(this, 0.5, St.Side.TOP)
  • extension.js:81
    this._menuManager = new PopupMenu.PopupMenuManager(this)
  • extension.js:486
    this._refreshWeatherMenuItem = new PopupMenu.PopupMenuItem(_('Refresh Weather'))

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:419
    this.dragBeginId = this._draggable.connect('drag-begin', this._onDragBegin.bind(this))
  • extension.js:420
    this.dragEndId = this._draggable.connect('drag-end', this._onDragEnd.bind(this))

All Versions

Version Status
16.0 (20) Active
16.0 (19) Rejected
15.3 (18) Active
15.2 (17) Active
15.1 (16) Active
15.0 (15) Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Rejected
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

SriramRamkrishna rejected
the shexli linter has a few issues. Please pip3 install shexli and then run it against your extension and fix whatever the output are. If you find some false errors, just let us know that when you resubmit. Thanks.