Review of "Power Switching Manager" version 1.1.0 (3)

Details Page Preview

Automatically switch theme and brightness based on power state

Extension Homepage
https://github.com/josbarros/power-switching-manager

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-006 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

  • prefs.js:12
    this.#settings = this.getSettings()

EGO-M-008 warning

extensions using unlock-dialog must document it in disable() comments

Extensions using `unlock-dialog` should document the reason in `disable()` comments.

Session Modes

  • extension.js:88
        disable() {
            this.#userSettingsClient?.disconnectObject(this)
            this.#powerClient?.disconnectObject(this)
    
            this.#userSettingsClient = null
            this.#gnomeSettingsClient = null
            this.#powerClient = null
            this.#keyboardClient = null
        }

All Versions

Version Status
1.2.0 (5) Active
1.1.0 (4) Active
1.1.0 (3) Rejected
1.0.0 (2) Active
1.0.0 (1) Rejected

Previous Reviews on this Version

dlandau rejected
Please check the shexli messages