Review of "Pass Search" version 2

Details Page Preview

Quick search and retrieve passwords from pass (the standard unix password manager)

Extension Homepage
https://github.com/Togn3K/pass-search-gnome-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2 manual_review 1

Shexli found 3 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:311
    St.Clipboard.get_default()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:76
            this._searchEntry.clutter_text.connect('activate', () => {
                const children = this._resultBox.get_children();
                if (this._selectedIndex >= 0 && this._selectedIndex < children.length)
                    this._activateEntry(children[this._selectedIndex]._passEntry);
            })
  • extension.js:73
            this._searchEntry.connect('key-press-event', (_actor, event) => {
                return this._onSearchKeyPress(event);
            })
  • extension.js:70
            this._searchEntry.clutter_text.connect('text-changed', () => {
                this._updateResults(this._searchEntry.get_text());
            })
  • extension.js:42
            this.menu.connect('open-state-changed', (_menu, open) => {
                if (open) {
                    this._loadEntries();
                    GLib.timeout_add(GLib.PRIORITY_DEFAULT, 50, () => {
                        this._searchEntry.grab_key_focus();
                        return GLib.SOURCE_REMOVE;
     

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:45
                    GLib.timeout_add(GLib.PRIORITY_DEFAULT, 50, () => {
                        this._searchEntry.grab_key_focus();
                        return GLib.SOURCE_REMOVE;
                    })

All Versions

Version Status
2 Unreviewed
1 Rejected