Review of "Gnirehtet Control" version 1

Details Page Preview

Toggle the Gnirehtet reverse tethering from Gnome Quick Settings

Extension Homepage
https://github.com/mateusvmv/gnome-shell-extension-gnirehtet

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-X-002 warning

extensions should not use synchronous subprocess APIs in shell code

Shell code should avoid synchronous subprocess APIs like `GLib.spawn_command_line_sync()` and `GLib.spawn_sync()`.

Complete Examples

  • extension.js:35
    GLib.spawn_command_line_sync('pgrep -of "gnirehtet autorun"')

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:227
    this._settings = this.getSettings()

EGO-M-008 warning

extensions using unlock-dialog must document it in disable() comments

Extensions using `unlock-dialog` should document the reason in `disable()` comments.

Session Modes

  • extension.js:248
        disable() {
            if (this._sessionModeChangedId) {
                Main.sessionMode.disconnect(this._sessionModeChangedId);
                this._sessionModeChangedId = null;
            }
            if (this._indicator) {
                this._indicator.destroy();
                this._indicator = null;
            }
    

All Versions

Version Status
1 Unreviewed