Review "Rounded Corners (Wobble-Compatible)" version 2

Review of "Rounded Corners (Wobble-Compatible)" version 2

Details Page Preview

Rounded Corners (Wobble-Compatible)

Rounded window corners fully compatible with Compiz Windows Effect (wobbly windows). Corner rounding is implemented via a fragment-shader SDF in UV space so it never interferes with vertex-level deformation. No set_clip() calls are made, and the extension automatically ensures the correct effect-stack ordering relative to DeformEffect.

Extension Homepage: https://github.com/ametistyt/gnome-roundedcorners-wobble-fix

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 2

Shexli found 3 issues that may need reviewer attention.

EGO-C49-004 error

extensions targeting GNOME 49 must not call Meta.Window.get_maximized

This extension explicitly targets GNOME Shell 49 but still calls removed `Meta.Window.get_maximized()`.

Meta.Window

extension.js:336
```
metaWin.get_maximized ()
```
extension.js:339
```
metaWin.get_maximized ()
```
extension.js:375
```
metaWin.get_maximized ()
```

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

schemas/gschemas.compiled
```
schemas/gschemas.compiled
```

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

extension.js:392

        GLib.idle_add (GLib.PRIORITY_LOW, () => {
            this._ensureOrdering (actor);
            return GLib.SOURCE_REMOVE;
        })

All Versions

Version	Status
2	Unreviewed
1	Unreviewed