Review "Hacker News Reader" version 1 - GNOME Shell Extensions

Review of "Hacker News Reader" version 1

Details Page Preview

Hacker News Reader

by ebarrera

GNOME panel extension to view top Hacker News stories with inline previews and quick open actions.

Extension Homepage: https://github.com/ebarrera89/hacker-news-gnome-extension

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

extension.js:114

			this.menu.connect('open-state-changed', (_menu, open) => {
				if (open && this._stories.length === 0 && !this._loading)
					this._loadStories(true);
			})

EGO-L-008 warning

Soup.Session instances should be aborted during cleanup

Soup.Session instances should be aborted during cleanup.

Soup.Session.abort

extension.js:91
```
this._session = new Soup.Session()
```

All Versions

Version	Status
1	Unreviewed