EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

• lib/stats.js:34

  GLib.file_get_contents('/proc/cpuinfo')

• lib/stats.js:46

  GLib.file_get_contents('/proc/meminfo')

• lib/stats.js:81

  GLib.file_get_contents('/proc/uptime')

• lib/stats.js:101

  GLib.file_get_contents('/proc/stat')

• lib/stats.js:124

  GLib.file_get_contents('/proc/meminfo')

• lib/stats.js:144

  GLib.file_get_contents(`/sys/class/power_supply/${name}/capacity`)

• lib/stats.js:151

  GLib.file_get_contents(`/sys/class/power_supply/${name}/status`)

• lib/stats.js:161

  GLib.file_get_contents('/sys/class/drm/card0/device/gpu_busy_percent')

• lib/utils.js:13

  GLib.file_get_contents('/etc/os-release')

• lib/utils.js:23

  GLib.file_get_contents('/proc/version')

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

• extension.js:18

  this._settings = this.getSettings()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

• extension.js:101

  this._brightnessProxy.connect('g-properties-changed', updateBrightness)

• extension.js:99

  this._brightnessProxy.connect('notify::Brightness', updateBrightness)

• extension.js:100

  this._brightnessProxy.connect('notify::Percentage', updateBrightness)

• extension.js:81

  this._volumeControl.connect('default-sink-changed', () => this._setupVolumeStream())

• extension.js:126

          this._volumeControl.connect('default-source-changed', () => {
              this._setupMicStream();
              this._updateMicState();
          })

• extension.js:75

          this._volumeControl.connect('state-changed', (c, state) => {
              if (state === Gvc.MixerControlState.READY) {
                  this._setupVolumeStream();
                  this._updateMicState();
              }
          })

• extension.js:124

  this._volumeControl.connect('stream-added', () => this._updateMicState())

• extension.js:125

  this._volumeControl.connect('stream-removed', () => this._updateMicState())

EGO-M-008 warning

extensions using unlock-dialog must document it in disable() comments

Extensions using `unlock-dialog` should document the reason in `disable()` comments.

Session Modes

• extension.js:390

      disable() {
          if (this._monitorsChangedId) {
              Main.layoutManager.disconnect(this._monitorsChangedId);
              this._monitorsChangedId = null;
          }
          if (this._micMuteSignalId) {
              this._volumeControl.get_default_source()?.disconnect(this._micMuteSignalId