Review "RouterOS Monitor" version 1 - GNOME Shell Extensions

Review of "RouterOS Monitor" version 1

Details Page Preview

RouterOS Monitor

Monitor your Mikrotik RouterOS from the GNOME Shell top bar. Using RouterOS's `detect-internet` feature, you can see at a glance the if your router's ethernet or LTE interface is internet-connected. The LTE interface also shows sparklines that monitor cellular signal strength. This extension can copy error messages to the clipboard. Not affiliated with MikroTik.

Extension Homepage: https://github.com/KoolADE85/routeros-monitor

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 5 manual_review 1

Shexli found 6 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

ui/components/errorContent.js:18
```
St.Clipboard.get_default()
```

EGO-X-006 warning

extensions should not use lookupByURL or lookupByUUID for current extension access

Use `this`, `this.getSettings()` or `this.path` instead of `lookupByURL()` or `lookupByUUID()` for the current extension.

`extensionUtils`

ui/components/statusIcon.js:11
```
Extension.lookupByURL(import.meta.url)
```
ui/views/panelIndicator.js:39
```
Extension.lookupByURL(import.meta.url)
```
ui/views/panelIndicator.js:42
```
Extension.lookupByURL(import.meta.url)
```
ui/views/quickSettings.js:37
```
Extension.lookupByURL(import.meta.url)
```

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

schemas/gschemas.compiled
```
schemas/gschemas.compiled
```

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

ui/types.js

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

ui/views/quickSettings.js:27

this._bannerSection = new PopupMenu.PopupMenuSection()

ui/views/quickSettings.js:29

this._section = new PopupMenu.PopupMenuSection()

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

ui/views/quickSettings.js:27

this._bannerSection = new PopupMenu.PopupMenuSection()

ui/views/quickSettings.js:29

this._section = new PopupMenu.PopupMenuSection()

All Versions

Version	Status
1	Unreviewed