Review "Maximize Roundtrip" version 1 - GNOME Shell Extensions

Review of "Maximize Roundtrip" version 1

Details Page Preview

Maximize Roundtrip

macOS-style workspace management: maximizing or fullscreening a window moves it to a new dedicated workspace on the right, and restoring or closing it brings you back to the original workspace automatically. Multi-monitor safe.

Extension Homepage: https://github.com/samirseraj03/Workspace-Roundtrip

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 2

Shexli found 3 issues that may need reviewer attention.

EGO-C49-003 error

extensions targeting GNOME 49 must not call maximize or unmaximize with Meta.MaximizeFlags

This extension explicitly targets GNOME Shell 49 but still passes `Meta.MaximizeFlags` to `maximize()` or `unmaximize()`.

Meta.Window

src/windows/windowTracker.js:184
```
win.unmaximize(Meta.MaximizeFlags.BOTH)
```
src/workspace/workspaceManager.js:320
```
win.unmaximize(Meta.MaximizeFlags.BOTH)
```

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

schemas/gschemas.compiled
```
schemas/gschemas.compiled
```

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

src/input/keyboardGuards.js

All Versions

Version	Status
1	Unreviewed