EGO016 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

• extension.js:515

      this._debounceTimeoutId = GLib.timeout_add_seconds(
        GLib.PRIORITY_DEFAULT,
        1,
        () => {
          this._debounceTimeoutId = null;
          if (this._enabled) this._detectLocationAndLoadWeather();
          return GLib.SOURCE_REMOVE;
        },
      )

• extension.js:532

      this._networkReloadId = GLib.timeout_add_seconds(
        GLib.PRIORITY_DEFAULT,
        delaySec,
        () => {
          this._networkReloadId = null;
          if (this._enabled) this._detectLocationAndLoadWeather();
          return GLib.SOURCE_REMOVE;
        },
      )

• prefs.js:1146

        GLib.timeout_add(GLib.PRIORITY_DEFAULT, 1000, () => {
          try {
            tempFile.delete(null);
          } catch (e) {
  
          }
          return GLib.SOURCE_REMOVE;
        })

EGO033 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

• prefs.js:73

  this._session = new Soup.Session()

• prefs.js:568

      this._providerDetailsGroup = new Adw.PreferencesGroup({
        title: _("Provider Configuration"),
        description: _("Configure your selected weather provider")
      })

• prefs.js:574

      this._apiKeyRow = new Adw.PasswordEntryRow({
        title: _("API Key"),
        text: settings.get_string("weather-api-key") || ""
      })

• prefs.js:587

      this._customUrlRow = new Adw.EntryRow({
        title: _("Custom API URL"),
        text: settings.get_string("custom-weather-url") || ""
      })

• prefs.js:593

      this._providerInfoRow = new Adw.ActionRow({
        title: _("Provider Information"),
        activatable: false
      })

• prefs.js:471

      this._searchResultsGroup = new Adw.PreferencesGroup({
        title: _("Search Results"),
        visible: false
      })