Review of "Home Assistant Theme Switcher" version 1

Details Page Preview

Automatically switch GNOME theme based on Home Assistant lux sensor

Extension Homepage
https://codeberg.org/pandale/home-assistant-theme-switcher

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-001 warning

extension must not create GObject instances or modify shell before enable()

Resource creation or signal/source setup was found outside `enable()`.

Only use initialization for static resources

  • secret.js:5
    new Secret.Schema(
      `${APP_ID}.token`,
      Secret.SchemaFlags.NONE,
      {
        app: Secret.SchemaAttributeType.STRING,
        secret: Secret.SchemaAttributeType.STRING,
      },
    )

EGO-L-006 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

  • prefs.js:11
    this.settings = this.getSettings()

All Versions

Version Status
4 Unreviewed
3 Rejected
2 Rejected
1 Unreviewed