Review of "PortKiller" version 1.1.0 (2)

Details Page Preview

Monitor and kill processes by port. A developer tool for the GNOME top bar that lists all active listening ports and lets you kill any process with one click.

Extension Homepage
https://github.com/EAspotifi/portkiller

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:36
    this._settings.connect('changed::badge-display-mode', () => this._updateBadge())
  • extension.js:37
            this._settings.connect('changed::port-view-mode', () => {
                this._updateViewModeButtonIcon();
                this._renderPorts();
            })
  • extension.js:67
            this.menu.connect('open-state-changed', (menu, isOpen) => {
                if (isOpen) this._refresh();
            })

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:207
            GLib.timeout_add(GLib.PRIORITY_DEFAULT, 600, () => {
                this._refreshBtn.remove_style_class_name('spinning');
                return GLib.SOURCE_REMOVE;
            })
  • extension.js:441
                        GLib.timeout_add(GLib.PRIORITY_DEFAULT, 500, () => {
                            this._refresh();
                            return GLib.SOURCE_REMOVE;
                        })
  • extension.js:447
                        GLib.timeout_add(GLib.PRIORITY_DEFAULT, 1000, () => {
                            killBtn.remove_style_class_name('portkiller-kill-fail');
                            return GLib.SOURCE_REMOVE;
                        })
  • extension.js:478
            GLib.timeout_add(GLib.PRIORITY_DEFAULT, 400, () => {
                this._refresh();
                return GLib.SOURCE_REMOVE;
            })
  • extension.js:72
            GLib.timeout_add(GLib.PRIORITY_DEFAULT, 1500, () => {
                this._refresh();
                return GLib.SOURCE_REMOVE;
            })

All Versions

Version Status
1.1.0 (2) Unreviewed
1.0.0 (1) Rejected