Review of "Rudra" version 8

Details Page Preview

A powerful, keyboard-driven productivity launcher for GNOME. Features: • Lightning-fast App & File Search • AI Assistant (Gemini, Groq, Perplexity, Cohere, Ollama) • Clipboard History Manager • Custom Plugin System (Bash/Python) • Built-in Calculator & Quick Web Search (Google, YouTube, DuckDuckGo, Wikipedia) • Emoji & Icon Picker • Snippets Manager For bug reports or feature requests, please visit the official GitHub repository: https://github.com/NarkAgni/rudra/issues

Extension Homepage
https://github.com/narkagni/rudra

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO033 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

  • prefs.js:33
    this.settings = this.getSettings()

EGO030 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • src/browsers/EmojiBrowser.js:35
    file.load_contents(null)
  • src/services/ClipboardManager.js:67
    this._clipboardFile.load_contents(null)
  • src/services/PluginManager.js:49
    file.load_contents(null)
  • src/services/SnippetManager.js:71
    this._file.load_contents(null)

EGO016 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • src/services/SnippetManager.js:46
                        GLib.idle_add(GLib.PRIORITY_DEFAULT_IDLE, () => {
                            this._load();
                            return GLib.SOURCE_REMOVE;
                        })

All Versions

Version Status
8 Waiting for author
7 Active
6 Rejected
5 Rejected
4 Rejected
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

dlandau waiting for author
Those shexli suggestions seem relevant, could you look into those?