Review of "Glaunch" version 2

Details Page Preview

A keyboard driven window management tool.

Extension Homepage
https://github.com/lcasta7/Glaunch

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
2 Unreviewed
1 Rejected

Previous Reviews on this Version

luic7 posted a review
Thank you for the detailed feedback @JustPerfection! Here's what was addressed: 1. schemas/gschemas.compiled — Removed from the repository and added to .gitignore. The Makefile still compiles it locally as needed. 2. GitHub URL in metadata.json — Already present as "url": "https://github.com/lcasta7/Glaunch". 3. Object stored in class property (prefs.js) — Added a close-request handler to null out _settings when the preferences window closes. 4. Whitespace between methods — Fixed missing blank lines between method definitions. 5. run_dispose() — Removed the call entirely. 6. connectObject()/disconnectObject() — global.window_manager (WindowManager) is not a GObject so connectObject is not available on it at runtime. The manual handler array approach is kept for that object. Happy to revisit if there's a pattern I'm missing. 7. Keybinding lifecycle — Added a destroy() method to Launcher that removes all keybindings it registered. extension.js now calls launcher.destroy() on disable and reload instead of managing keybinding removal itself.