Review of "Data Toolkit" version 1

Details Page Preview

Panel utility for live upload and download speeds with transfer calculations. Github:


No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO015 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:126
    this._sizeEntry.clutter_text.connect('text-changed', () => this._updateCalculation())
  • extension.js:231
    button.connect('clicked', callback)

EGO030 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:252
    file.load_contents(null)

All Versions

Version Status
2 Unreviewed
1 Rejected

Previous Reviews on this Version

AnkitSharma posted a review
AnkitSharma auto- rejected
Auto-rejected because of new version 2 was uploaded
AnkitSharma posted a review
I 've updated the code and uploaded new zip file