Review of "Start Menu" version 2

Details Page Preview

A customizable start menu for GNOME Shell with category management, recent apps, and search functionality.

Extension Homepage
https://github.com/slim8916/start_menu

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:118
    file.load_contents(null)
  • extension.js:330
    file.load_contents(null)

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:531
                        GLib.idle_add(GLib.PRIORITY_DEFAULT_IDLE, () => {
                            Main.overview.viewSelector?.showApps?.();
                            return GLib.SOURCE_REMOVE;
                        })
  • extension.js:629
                        GLib.idle_add(GLib.PRIORITY_DEFAULT_IDLE, () => {
                            this.menuItemSearch.searchEntry.grab_key_focus();
                            return GLib.SOURCE_REMOVE;
                        })

All Versions

Version Status
2 Unreviewed
1 Rejected