Review of "LAN Scanner" version 1

Details Page Preview

Scans local network and displays connected devices (IP, MAC, hostname)

Extension Homepage
https://github.com/mdoksa76/lan-scanner

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-002 warning

extensions should not use synchronous subprocess APIs in shell code

Shell code should avoid synchronous subprocess APIs like `GLib.spawn_command_line_sync()` and `GLib.spawn_sync()`.

Complete Examples

  • extension.js:109
    GLib.spawn_command_line_sync('ip -4 addr show')
  • extension.js:298
    GLib.spawn_command_line_sync('ip neigh show')
  • extension.js:316
    GLib.spawn_command_line_sync(`arp -n ${ip}`)
  • extension.js:428
    GLib.spawn_command_line_sync(`getent hosts ${ip}`)
  • extension.js:444
    GLib.spawn_command_line_sync(`timeout 1 nmblookup -A ${ip} 2>/dev/null`)
  • extension.js:464
    GLib.spawn_command_line_sync(`avahi-resolve-address ${ip} 2>/dev/null`)
  • extension.js:481
    GLib.spawn_command_line_sync(`dig +short -x ${ip} 2>/dev/null`)
  • extension.js:534
    GLib.spawn_command_line_sync(`ping -c 1 ${ip} 2>/dev/null | grep -o "ttl=\\d+"`)
  • extension.js:636
    GLib.spawn_command_line_sync('ip link show')

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:296
            GLib.timeout_add(GLib.PRIORITY_DEFAULT, 100, () => {
                try {
                    let [ok, out] = GLib.spawn_command_line_sync('ip neigh show');
                    if (ok) {
                        let output = new TextDecoder().decode(out);
                        let lines = output.split('\n');
    

All Versions

Version Status
2 Unreviewed
1 Rejected

Previous Reviews on this Version

mdoksa auto- rejected
Auto-rejected because of new version 2 was uploaded