Review of "Chinese Calendar" version 4

Details Page Preview

在 GNOME 顶栏时钟和日历卡片中显示中国农历日期、节气、传统节日和法定节假日信息 Display Chinese lunar dates, solar terms, traditional festivals, and statutory holidays in the GNOME top bar clock and dropdown calendar card area.

Extension Homepage
https://github.com/tigertall/chinese-calendar

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO025 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO016 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • prefs.js:124
                    GLib.timeout_add(GLib.PRIORITY_DEFAULT, 3000, () => {
                        if (updateButton && !updateButton.is_destroyed?.()) {
                            updateButton.label = '立即更新';
                        }
                        return GLib.SOURCE_REMOVE;
                    })

All Versions

Version Status
5 Unreviewed
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

tigertall auto- rejected
Auto-rejected because of new version 5 was uploaded