Review of "Window Calls Extended" version 10

Details Page Preview

Add new dbus call for windows to get windows list and some of theirs properties, plus details on window under focus. Can be used by tools such as espanso.

Extension Homepage
https://github.com/hseliger/window-calls-extended

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-C49-004 error

extensions targeting GNOME 49 must not call Meta.Window.get_maximized

This extension explicitly targets GNOME Shell 49 but still calls removed `Meta.Window.get_maximized()`.

Meta.Window

  • extension.js:67
    w.get_maximized()

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:55
    this._dbus = Gio.DBusExportedObject.wrapJSObject(MR_DBUS_IFACE, this)

All Versions

Version Status
11 Active
10 Rejected
9 Inactive
8 Inactive
7 Inactive
6 Inactive
5 Inactive
4 Active
3 Inactive
2 Inactive
1 Inactive

Previous Reviews on this Version

hseliger auto- rejected
Auto-rejected because of new version 11 was uploaded