GNOME Shell Extensions

Review of "Dual Monitor Toggle" version 13

Details Page Preview

Dual Monitor Toggle

by poka

Easily enable or disable your secondary monitor with a single click. This extension adds a toggle button to the system menu, allowing you to quickly switch your second screen on or off without needing to navigate through settings. It automatically detects your connected monitors and their configurations, making it simple to manage your multi-monitor setup.

Extension Homepage
https://github.com/poka-IT/gnome-dual-monitor-toggle
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO025 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

  • __MACOSX/._LICENSE 
    __MACOSX/._LICENSE
  • __MACOSX/._lib 
    __MACOSX/._lib
  • __MACOSX/._README.md 
    __MACOSX/._README.md
  • __MACOSX/._metadata.json 
    __MACOSX/._metadata.json
  • __MACOSX/._stylesheet.css 
    __MACOSX/._stylesheet.css
  • __MACOSX/._schemas 
    __MACOSX/._schemas
  • __MACOSX/._extension.js 
    __MACOSX/._extension.js
  • __MACOSX/schemas/._org.gnome.shell.extensions.dual-monitor-toggle.gschema.xml 
    __MACOSX/schemas/._org.gnome.shell.extensions.dual-monitor-toggle.gschema.xml
  • __MACOSX/lib/._logger.js 
    __MACOSX/lib/._logger.js
  • __MACOSX/lib/._xmlReader.js 
    __MACOSX/lib/._xmlReader.js

EGO026 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • __MACOSX/._extension.js
  • __MACOSX/lib/._dbusService.js
  • __MACOSX/lib/._indicator.js
  • __MACOSX/lib/._logger.js
  • __MACOSX/lib/._menu.js
  • __MACOSX/lib/._toggle.js
  • __MACOSX/lib/._xmlReader.js

EGO030 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • lib/xmlReader.js:13 
    GLib.file_get_contents(path)

All Versions

Version Status
13 Rejected
12 Rejected
11 Rejected
10 Active
9 Rejected
8 Active
7 Active
6 Rejected
5 Active
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

dlandau rejected
As mentioned in previous review, pelase remove __MACOSX directory