Review of "Text to Speech — Piper Reader" version 2

Details Page Preview

Speak selected text using Piper neural TTS. Select any text, press Shift+Super+A (configurable) and it reads it aloud. Natural-sounding offline voices via Piper. Panel icon shows idle / thinking / speaking state. Full settings: voice picker, speed, expressiveness, custom shortcut.

Extension Homepage
https://github.com/gchiqo/piper-tts-gchiqo

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 3

Shexli found 4 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:67
    file.load_contents(null)

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-P-002 error

GSettings schema path must use /org/gnome/shell/extensions base

GSettings schema path must start with `/org/gnome/shell/extensions`.

GSettings Schemas

  • schemas/org.gnome.shell.extensions.piper-tts.gschema.xml
    id='org.gnome.shell.extensions.piper-tts' path='/org.gnome.shell.extensions.piper-tts/'

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:124
            this._settings.connect('changed::shortcut', () => {
                this._unbindShortcut();
                this._bindShortcut();
            })

All Versions

Version Status
2 Unreviewed
1 Rejected