Review of "ISS Detector" version 1

Details Page Preview

Notify you 10 minutes before the ISS passes overhead (manual or dynamic location).

Extension Homepage
https://github.com/gyiptgyipt/iss-detector-gnome-extension

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:401
    _countdownLabel = new St.Label({ text: '--', style_class: 'iss-countdown', x_align: Clutter.ActorAlign.START })
  • extension.js:479
    _issStatsLabel = new St.Label({ text: 'H: -- km  V: -- km/h', style_class: 'iss-status', x_align: Clutter.ActorAlign.START })
  • extension.js:409
      _latEntry = new St.Entry({
        text: '',
        hint_text: 'Latitude',
        x_expand: true,
        can_focus: true,
      })
  • extension.js:415
      _lonEntry = new St.Entry({
        text: '',
        hint_text: 'Longitude',
        x_expand: true,
        can_focus: true,
      })
  • extension.js:427
      _mapActor = new St.Widget({
        width: MAP_WIDTH,
        height: MAP_HEIGHT,
        x_expand: true,
        y_expand: false,
        style_class: 'iss-map',
        reactive: true,
      })
  • extension.js:435
    _mapCanvas = new Clutter.Canvas()
  • extension.js:440
      _mapContainer = new St.Widget({
        width: MAP_WIDTH,
        height: MAP_HEIGHT,
        x_expand: true,
        y_expand: false,
        layout_manager: new Clutter.BinLayout(),
      })
  • extension.js:406
    _statusLabel = new St.Label({ text: 'Waiting for location…', style_class: 'iss-status', x_align: Clutter.ActorAlign.START })
  • extension.js:402
    _timeLabel = new St.Label({ text: 'Next pass: unknown', style_class: 'iss-nextpass', x_align: Clutter.ActorAlign.END, x_expand: true })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:437
    _mapCanvas.connect('draw', _drawMap)

EGO-L-007 warning

main loop sources should be removed before being recreated

Main loop sources should be removed before creating a new source on the same field.

Remove main loop sources

  • extension.js:109
      _timeoutId = GLib.timeout_add_seconds(GLib.PRIORITY_DEFAULT, CHECK_INTERVAL_SEC, () => {
        _checkPasses();
        return GLib.SOURCE_CONTINUE;
      })
  • extension.js:114
      _issTimerId = GLib.timeout_add_seconds(GLib.PRIORITY_DEFAULT, ISS_POSITION_INTERVAL_SEC, () => {
        _fetchIssPosition();
        return GLib.SOURCE_CONTINUE;
      })

All Versions

Version Status
1 Unreviewed

Previous Reviews on this Version

Zyme posted a review
all fine except Next pass API