GNOME Shell Extensions

Review of "Battery Limit" version 2

Details Page Preview

Battery Limit

by adityagupta.code

Set battery charge limit (60/80/100) from GNOME panel. Replaced notify-send with Main.notify as suggested by reviewer. Removed dependency on external notification tools.

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:46 
                    setTimeout(() => {
                    Main.notify("Battery Limit", `${text} applied successfully`);
                }, 5000)

All Versions

Version Status
2 Unreviewed
1 Rejected