Review of "System Monitor" version 3

Details Page Preview

Real-time system resource monitoring in the top bar — CPU, RAM, temperature, disk usage & I/O, network I/O, GPU, and power/energy tracking

Extension Homepage
https://github.com/JTourteau/gnome-system-monitor

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:489
    this._box = new St.BoxLayout({ style_class: 'panel-status-indicators-box' })
  • extension.js:492
            this._cpuLabel = new St.Label({
                text: 'CPU: --%',
                y_align: Clutter.ActorAlign.CENTER,
                style: 'font-size: 11px; padding: 0 4px;',
            })
  • extension.js:507
            this._diskLabel = new St.Label({
                text: 'DISK: --%',
                y_align: Clutter.ActorAlign.CENTER,
                style: 'font-size: 11px; padding: 0 4px;',
            })
  • extension.js:524
            this._gpuLabel = new St.Label({
                text: 'GPU: --',
                y_align: Clutter.ActorAlign.CENTER,
                style: 'font-size: 11px; padding: 0 4px;',
            })
  • extension.js:513
            this._ioLabel = new St.Label({
                text: 'I/O: --',
                y_align: Clutter.ActorAlign.CENTER,
                style: 'font-size: 11px; padding: 0 4px;',
            })
  • extension.js:703
    this._menuCpuItem = new PopupMenu.PopupMenuItem('', { reactive: false })
  • extension.js:744
    this._menuDiskItem = new PopupMenu.PopupMenuItem('', { reactive: false })
  • extension.js:761
    this._menuIOReadItem = new PopupMenu.PopupMenuItem('', { reactive: false })
  • extension.js:763
    this._menuIOWriteItem = new PopupMenu.PopupMenuItem('', { reactive: false })
  • extension.js:780
    this._menuNetRxItem = new PopupMenu.PopupMenuItem('', { reactive: false })
  • extension.js:782
    this._menuNetTxItem = new PopupMenu.PopupMenuItem('', { reactive: false })
  • extension.js:721
    this._menuRamItem = new PopupMenu.PopupMenuItem('', { reactive: false })
  • extension.js:738
    this._menuTempItem = new PopupMenu.PopupMenuItem('', { reactive: false })
  • extension.js:519
            this._netLabel = new St.Label({
                text: 'NET: --',
                y_align: Clutter.ActorAlign.CENTER,
                style: 'font-size: 11px; padding: 0 4px;',
            })
  • extension.js:529
            this._powerLabel = new St.Label({
                text: 'PWR: --',
                y_align: Clutter.ActorAlign.CENTER,
                style: 'font-size: 11px; padding: 0 4px;',
            })
  • extension.js:497
            this._ramLabel = new St.Label({
                text: 'RAM: --%',
                y_align: Clutter.ActorAlign.CENTER,
                style: 'font-size: 11px; padding: 0 4px;',
            })
  • extension.js:502
            this._tempLabel = new St.Label({
                text: 'TEMP: --',
                y_align: Clutter.ActorAlign.CENTER,
                style: 'font-size: 11px; padding: 0 4px;',
            })

All Versions

Version Status
3 Unreviewed
2 Rejected
1 Rejected