Review of "Show Apps Animation" version 2

Details Page Preview

Adds a scale down click animation to app icons launched from the Show Apps grid.

Extension Homepage
https://github.com/omaranos517/gnome-show-apps-animation

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:39
                            GLib.timeout_add(GLib.PRIORITY_DEFAULT, RESET_DELAY_MS, () => {
                                appIcon._scaleDownAnimationInFlight = false;
                                return GLib.SOURCE_REMOVE;
                            })

All Versions

Version Status
3 Unreviewed
2 Rejected
1 Active

Previous Reviews on this Version

Omar Anoss auto- rejected
Auto-rejected because of new version 3 was uploaded