Review of "Dock Window Previews" version 1

Details Page Preview

Windows-style window previews for your dock. Hover any app icon to see live previews of all its open windows. Supports bottom, top, left and right dock positions.

Extension Homepage
https://emmurbinag.gumroad.com/

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 5

Shexli found 5 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

  • install.sh
    install.sh

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:429
    this._settings=this.getSettings('org.gnome.shell.extensions.dock-window-previews')

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:498
    this._dragEdge.connect('notify::hover', ()=>{ if(this._dragEdge.hover)this._revealDock(); })

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:196
            GLib.timeout_add(GLib.PRIORITY_DEFAULT, 300, () => {
                if (!container.get_stage()) return GLib.SOURCE_REMOVE;
                tryAttachClone(); return GLib.SOURCE_REMOVE;
            })
  • extension.js:437
            GLib.timeout_add(GLib.PRIORITY_DEFAULT, 1500, ()=>{
                this._scanIcons();
                this._setupDragEdge();
                return GLib.SOURCE_REMOVE;
            })

All Versions

Version Status
1 Unreviewed