Review of "Raven Sidebar" version 2

Details Page Preview

A unified sidebar with calendar, notifications, and quick settings.

Extension Homepage
https://github.com/dalpat/raven-sidebar

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 2

Shexli found 3 issues that may need reviewer attention.

EGO011 error

GSettings schema XML must be present in package

Extension appears to use GSettings but no `.gschema.xml` file is included in the package.

GSettings Schemas

EGO030 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • components/BrightnessSection.js:40
    file.load_contents(null)

EGO015 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:43
            this._button.connect('button-press-event', () => {
                this._sidebar.toggle();
                return Clutter.EVENT_STOP;
            })

All Versions

Version Status
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

Dalpat Singh auto- rejected
Auto-rejected because of new version 3 was uploaded