Review of "Nightscout" version 1.8.0 (14)

Details Page Preview

Integration with Nightscout to display its data

Extension Homepage
https://github.com/jeroenwtf/gnome-nightscout

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO025 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO015 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:104
            this._notifSource.connect("destroy", () => {
              this._notifSource = null;
            })
  • extension.js:244
          this._showDeltaItem.connect("toggled", (item) => {
            settings.set_boolean("show-delta", item.state);
          })
  • extension.js:266
          this._showElapsedTimeItem.connect("toggled", (item) => {
            settings.set_boolean("show-elapsed-time", item.state);
          })
  • extension.js:277
          this._showStaleElapsedTimeItem.connect("toggled", (item) => {
            settings.set_boolean("show-stale-elapsed-time", item.state);
          })
  • extension.js:255
          this._showTrendArrowsItem.connect("toggled", (item) => {
            settings.set_boolean("show-trend-arrows", item.state);
          })

EGO037 warning

Soup.Session instances should be aborted during cleanup

Soup.Session instances should be aborted during cleanup.

Soup.Session.abort

  • extension.js:86
    this.httpSession = new Soup.Session()

All Versions

Version Status
1.8.1 (17) Active
1.8.1 (16) Rejected
1.8.0 (15) Active
1.8.0 (14) Rejected
1.7.0 (13) Active
1.7.0 (12) Rejected
1.6.0 (11) Active
1.5.0 (10) Active
1.5.0 (9) Rejected
8 Active
7 Active
6 Active
5 Active
4 Rejected
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

dlandau waiting for author
Please check the shexli comments
Jeroen van Meerendonk auto- rejected
Auto-rejected because of new version 1.8.0 (15) was uploaded